572890 - fix "octal literals and octal escape sequences are deprecated" in c-c

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Karsten Düsterloh]

Attachment: fix octal deprecation warnings in c-c

Since bug 514559, octal literals and octal escape sequences are deprecated in strict mode, resulting in *lots* of 

JS Component Loader: WARNING chrome://messenger-newsblog/content/file-utils.js:231
                     octal literals and octal escape sequences are deprecated

warnings when starting trunk SeaMonkey or Thunderbird with JS strict mode enabled, cluttering the error console.

Comment 1

[Jim Porter (:squib)]

Wouldn't it make more sense to use hex? Or use the bit shift idiom?

...
const PERM_IRWXO = 1 << 3;
const PERM_IROTH = 1 << 2;
const PERM_IWOTH = 1 << 1;
const PERM_IXOTH = 1 << 0;

In any case, the current patch needs closing parens on most of the parseInt calls, if nothing else.

Comment 2

[Jim Porter (:squib)]

Sorry, I guess it's not as simple as bit shifting. But hex would work.

Comment 3

[David :Bienvenu]

Comment on attachment 452112 [details] [diff] [review]
fix octal deprecation warnings in c-c

asuth might have some thoughts on the nicest way of doing this.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 452112 [details] [diff] [review]
fix octal deprecation warnings in c-c

parseInt seems like the right way to go here.  File attributes are usually expressed in octal, so use of parseInt seems consistent and (most) intuitive.

As noted, there are a bunch of parens missing and there is also a plus sign missing on PERM_RW_ALL.  Strictly speaking from a nit perspective, bitwise-or ("|") is preferable, but it ends up the same, so who cares.

r=asuth conditional on fixing the syntax errors.

Thanks for taking the initiative to fix this; I find that error annoying too!

Comment 5

[David :Bienvenu]

Comment on attachment 452112 [details] [diff] [review]
fix octal deprecation warnings in c-c

thx, Karsten, sr + conditional on the same issues...

Comment 6

[Karsten Düsterloh]

Attachment: v2, updated to comments

Landed in comm-central as <http://hg.mozilla.org/comm-central/rev/ff4b8b04a116>.

Comment 7

[Philip Chee]

> +/* Notice that these valuse are octal, but octal literals are deprecated. */

Karsten, your valuse are misspelled.

Comment 8

[Karsten Düsterloh]

*argl* I plead for not correcting an already present misspelling. :|
Also, it probably should be "Note" instead of "Notice"...